FDM 2.1 build 494 Firefox extension causing serious crashes

Benni-chan · Postby **Benni-chan** » Thu Nov 22, 2007 9:22 pm

Hi,

I took a look at the source code (as far as I could get ^^) and the error is in the file "fdm_ffext.js" in the function "fdm_contextPopupShowing ()".
Firefox crashes, when "fdm_FDM.GetLngString()" is executed.

For a quick Fix exchange the function in your C:\Program Files\Free Download Manager\Firefox\extension\chrome\content\fdm_ffext.js with the following one:

(line 106)

Code: Select all

function fdm_contextPopupShowing ()
{
  var menuitem = document.getElementById("fdm-context-item-dllink");
  
  //menuitem.label  = fdm_FDM.GetLngString ("dllink");
  menuitem.label = "Download by FDM";
  menuitem.hidden = fdm_FDM.IsContextMenuItemShouldBeHidden ("dllink") || 
     !fdm_checkURL (fdm_getURL (document.popupNode));

  menuitem = document.getElementById("fdm-context-item-dlall");
  //menuitem.label  = fdm_FDM.GetLngString ("dlall");
  menuitem.label = "Download all by FDM";
  menuitem.hidden = fdm_FDM.IsContextMenuItemShouldBeHidden ("dlall");

  menuitem = document.getElementById("fdm-context-item-dlselected");
  //menuitem.label  = fdm_FDM.GetLngString ("dlselected");
  menuitem.label = "Download selected by FDM";
  menuitem.hidden = fdm_FDM.IsContextMenuItemShouldBeHidden ("dlselected") ||
     document.commandDispatcher.focusedWindow.getSelection().isCollapsed;

  menuitem = document.getElementById("fdm-context-item-dlvideo");
  //menuitem.label  = fdm_FDM.GetLngString ("dlvideo");
  menuitem.label = "Download video by FDM";
  menuitem.hidden = fdm_FDM.IsContextMenuItemShouldBeHidden ("dlvideo") ||
     fdm_checkHasVideo () == false;

  menuitem = document.getElementById("fdm-context-item-separator");
  menuitem.hidden = fdm_FDM.IsContextMenuItemShouldBeHidden ("separator1");
}

if you don't like the english text, just translate it yourself by changing the text behind menuitem.label.

hope you can fix this, so the language support will be back

antini · Postby **antini** » Sun Nov 25, 2007 6:09 am

Can this bug be fixed? Some ideas have been posted on bugzilla. Firefox 3 beta 1 is out now.

Lost as Usual · Postby **Lost as Usual** » Thu Nov 29, 2007 7:12 pm

Similar strange problem with FDM 2.5, Build 721, and Firefox Beta1 (Windows XP, SP2): Highlight some text, right-click, Firefox crashes.

I don't think just right-clicking causes a crash--but I did not know about that until reading this thread, and as I'm in Beta1, I don't want to test it....

glynor · Postby **glynor** » Thu Feb 14, 2008 3:17 pm

First off... Hello all! I'm a big fan of FDM. It is among the first things I install on new machines. I took the time to register for this forum because of this bug however...

I've been struggling with this bug for some time. I use Minefield on my HTPC because of the full-page zoom feature (among other things). Either way, I thought I'd mention that this is certainly still a problem. I am completely unable to use FDM with Minefield on my systems.

Firefox 3.0 (Minefield) Beta 3 is now out. According to the minutes of the last Status Meeting, the plan is for Beta 4 to be the final Beta release before the official release, which is scheduled for "early 2008" (final date TBD).

Not only that, but recent reviews have deemed it "very close to being ready for widespread adoption" (something borne out if you've actually used any of the recent nightlies or beta builds). It is quite polished. There are still, of course, a few minor issues, but it is feature complete, stable, and they are well into bug-quashing-only mode.

I guess my point here is that we are no longer in a place where "it's alpha software, what are you complaining for?" is going to cut it. The release is around the corner, and now seems like it would be the time to fix the problems so that your plugin is ready to go for the official release, which could be coming very shortly (I would guess within a month based on following the progress fairly closely over at MozillaZine).

Here's hoping, because I absolutely love FDM and would be very sad to have to abandon it for Firefox 3 (which I also absolutely love).

Guest · Postby **Guest** » Thu Feb 14, 2008 3:33 pm

FMD Version 2.5, build 247, works correctly with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021404 Minefield/3.0b4pre - Build ID: 2008021404. That release of Minefield is the latest nightly; FDM has been working with nightly releases for some time now.

I did have a repeat of this problem recently, which was quickly fixed by installing the latest version of FDM: Delete the FDM extension from Firefox/Minefield, then have FDM monitor the browser,which installs the latest version of the FDM extension.

Lost as Usual · Postby **Lost as Usual** » Thu Feb 14, 2008 3:36 pm

On the other hand, the forum software might be having a bit of a problem: Despite my having been logged on to the forum, my reply to you about the latest version of FDM working with Minefield, my reply was posted as being from Guest.

Had it called me "Guess," well, that might have been more accurate....

glynor · Postby **glynor** » Thu Feb 14, 2008 9:07 pm

Anonymous wrote:I did have a repeat of this problem recently, which was quickly fixed by installing the latest version of FDM: Delete the FDM extension from Firefox/Minefield, then have FDM monitor the browser,which installs the latest version of the FDM extension.

I'll have to try this because I am using the current FDM and the latest Minefield nightly (well, the one from yesterday), and it was still crashing reliably on right-click.

I saw in the Sourceforge changelog for FDM that it was listed as compatible, but figured that this was still not fixed...

Lost as Usual · Postby **Lost as Usual** » Thu Feb 14, 2008 9:31 pm

I read your reply, right-clicked, no crash--nor have there been any crashes since my last update to FDM, including the replacement of the FDM extension in Minefield.

I don't know if it was my update to FDM, or my then replacing the extension, as I did both at much the same time; that is, I did not first update FDM and test to see if Minefield still crashed when right-clicking. I can only recommend that extension replacement if you've not so done.

Well, I could recommend one other thing: If Minefield continues to crash, don't right click....

glynor · Postby **glynor** » Fri Feb 15, 2008 2:35 pm

Lost as Usual wrote:I read your reply, right-clicked, no crash--nor have there been any crashes since my last update to FDM, including the replacement of the FDM extension in Minefield.

I don't know if it was my update to FDM, or my then replacing the extension, as I did both at much the same time; that is, I did not first update FDM and test to see if Minefield still crashed when right-clicking. I can only recommend that extension replacement if you've not so done.

Well, I could recommend one other thing: If Minefield continues to crash, don't right click....

I re-installed FDM and it fixed it. I had installed Minefield after I already had FDM installed, and it was certainly still crashing. I "uninstalled" the FDM Addon from inside Minefield, downloaded the newest build of FDM off of Sourceforge, and installed it and all is good and right with the world now.

Thanks!

Guest · Postby **Guest** » Mon Mar 17, 2008 8:57 am

fdm extension version 1.3.1 (and earlier) are now blacklisted on firefox 3.0

https://bugzilla.mozilla.org/show_bug.cgi?id=408445

Lost as Usual · Postby **Lost as Usual** » Mon Mar 17, 2008 10:33 am

Yes, FDM is blocked, but that can be bypassed, at least with the nightly releases of Minefield. I don't know if this works with the beta releases.

1. In Minefield, open about:config.

2. In the Filter box, enter extenions.blocklist.enabled.

3. When you find that entry, toggle it to false.

4. Close about:config.

5. Open Tools, Addons, delete the FDM Extension.

6. Open FDM, set it to monitor Firefox.

7. Restart Firefox (Minefield); FDM should now work again--at least it has for me since I did steps 1-6 above.

[EDIT] I just read, in another thread on this forum, that there is now a FDM extension version 1.32, obtained by downloading the latest release of FDM, that fixes the problem.

FDM 2.1 build 494 Firefox extension causing serious crashes

quick fix

Who is online